Add .gitlab.yml and veracode upload script #15
Conversation
ystefinko
requested review from
OleksiiZubko,
leonid-ziskel,
mykhailo-kuchma and
andescu
scripts/veracode/veracodeUpload.sh
Outdated
| # Examples: | ||
| # veracodeUpload.sh /tmp/veracode.war [email protected] 443849 1.0.0-RC1 | ||
| # | ||
| LATEST_TAG=$(git describe --tags) |
There was a problem hiding this comment.
why do you take the latest tag. Maybe better the commit hash the script used to run the scanner on?
There was a problem hiding this comment.
From my side, when I get email with title
"SPC - Veracode results for OLP EDGE Enablers (TypeScript) Build olp-edge-ts-v0.9.1-1-g94ca2be-168 Policy Compliance=Pass Score=99"
is better than :
"SPC - Veracode results for OLP EDGE Enablers (TypeScript) Build olp-edge-ts-1-g94ca2be-168 Policy Compliance=Pass Score=99"
because second does not give us any versioning information.
This hash (g94ca2be) is random data generated by Veracode, but not by our commit hash on Github (01db17a).
What is your suggestion then?
There was a problem hiding this comment.
my suggestion would be olp-edge-ts-01db17a-1-g94ca2be-168, i.e. to take the git hash commit instead of the tag. Reason: we ran the scanner on the master and not on the tag
There was a problem hiding this comment.
updated.
Chosen your suggestion as its more clear for you and Oleksii.
ystefinko
force-pushed
the
task/olpedge-804
branch
from
c02c8fd
to
dec2ed6
Compare
ystefinko
force-pushed
the
task/olpedge-804
branch
3 times, most recently
from
b6a0c50
to
ca0e31a
Compare
Added 2 files: - gitlab yml is for Pipeline setup on Gitlab for scheduled scan for security (weekly or other,schedule setting is on UI of Gitlab in Pipeline > Schedules) - bash scripts which do packing all .ts files into zip and upload to Veracode Static Scan Two hidden variables will be defined in Gitlab Project Setting: VERACODE_API_PWD, VERACODE_API_USER. Resolves: OLPEDGE-804 Signed-off-by: Yaroslav Stefinko <[email protected]>
ystefinko
force-pushed
the
task/olpedge-804
branch
from
ca0e31a
to
0d6445c
Compare
Added 2 files:
Two hidden variables will be defined in Gitlab Project Setting: VERACODE_API_PWD, VERACODE_API_USER.
Resolves: OLPEDGE-804
Signed-off-by: Yaroslav Stefinko [email protected]