Align Version and Volatile Layers with DatastoreApi #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriyShevchuk
requested review from
iriza7,
OleksiiZubko,
leonid-ziskel and
andescu
AndriyShevchuk
force-pushed
the
task/olpedge-822
branch
from
f4a09b8
to
d4b8a2c
Compare
Despite on datastore-api has methods to create URLs for downloading data, URLs were created with custom methods on the datastore-read side To use correct API replace redundant methods for creating URLs to download data with propriate methods from @here/olp-sdk-datastore-api Create method downloadBlob in requestBuilder to dowbload blob object data Move LayerSummary interface to the coverage-api Update tests Resolves: OLPEDGE-822 Signed-off-by: ashevchu <[email protected]>
AndriyShevchuk
force-pushed
the
task/olpedge-822
branch
3 times, most recently
from
eb26609
to
80497f2
Compare
Despite on datastore-api has methods to create URLs for downloading data, URLs were created with custom methods on the datastore-read side To use correct API replace redundant methods for creating URLs to download data with propriate methods from @here/olp-sdk-datastore-api Create method downloadBlob in requestBuilder to dowbload blob object data Move LayerSummary interface to the coverage-api Update tests Resolves: OLPEDGE-822 Signed-off-by: ashevchu <[email protected]>
AndriyShevchuk
force-pushed
the
task/olpedge-822
branch
from
80497f2
to
ecd6089
Compare
OleksiiZubko
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite on datastore-api has methods to create URLs for downloading data, URLs were created with custom methods on the datastore-read side
To use correct API replace redundant methods for creating URLs to download data with propriate methods from @here/olp-sdk-datastore-api
Create method downloadBlob in requestBuilder to dowbload blob object data
Move LayerSummary interface to the coverage-api
Update tests
Resolves: OLPEDGE-822
Signed-off-by: ashevchu [email protected]