Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt PartitionsCacheRepository to use Write #1521

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

andrey-kashcheev
Copy link
Collaborator

@andrey-kashcheev andrey-kashcheev commented Jun 13, 2024

This is necessary to move forward with advanced cache error handling.

This commit also includes new way of serializing to bytes vector.

Relates-To: OCMAM-61

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 79.62963% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.44%. Comparing base (ff510e8) to head (390be27).

Files Patch % Lines
...ead/src/repositories/PartitionsCacheRepository.cpp 75.00% 1 Missing and 6 partials ⚠️
...e-read/src/generated/serializer/ByteVectorBuffer.h 84.62% 1 Missing and 1 partial ⚠️
olp-cpp-sdk-core/src/cache/DefaultCacheImpl.cpp 50.00% 1 Missing ⚠️
...vice-read/src/repositories/DataCacheRepository.cpp 66.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1521      +/-   ##
==========================================
- Coverage   81.46%   81.44%   -0.02%     
==========================================
  Files         342      344       +2     
  Lines       13511    13540      +29     
  Branches     1453     1455       +2     
==========================================
+ Hits        11006    11027      +21     
+ Misses       1924     1921       -3     
- Partials      581      592      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrey-kashcheev andrey-kashcheev changed the title Added KeyValueCache::Write variant with boost::any Adapt cache repositories to use Write Jun 14, 2024
@andrey-kashcheev andrey-kashcheev force-pushed the ocmam-61-encoded-write branch 2 times, most recently from 921a01b to 47b9dc6 Compare June 14, 2024 17:03
@andrey-kashcheev andrey-kashcheev changed the title Adapt cache repositories to use Write Adapt cache PartitionsCacheRepository to use Write Jun 14, 2024
@andrey-kashcheev andrey-kashcheev changed the title Adapt cache PartitionsCacheRepository to use Write Adapt PartitionsCacheRepository to use Write Jun 14, 2024
This is necessary to move forward with advanced cache error handling.

This commit also includes new way of serializing to bytes vector.

Relates-To: OCMAM-61
Signed-off-by: Andrey Kashcheev <[email protected]>
@andrey-kashcheev andrey-kashcheev merged commit c3dce00 into master Jun 17, 2024
21 of 22 checks passed
@andrey-kashcheev andrey-kashcheev deleted the ocmam-61-encoded-write branch June 17, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants