Update logic around DataCallback #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take into account that we may detach request and the fact that data callback may be missing in some cases. Relates-To: OLPEDGE-2444 Signed-off-by: Andrey Kashcheev <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1518 +/- ##
==========================================
- Coverage 81.50% 81.42% -0.08%
==========================================
Files 341 342 +1
Lines 13417 13507 +90
Branches 1447 1453 +6
==========================================
+ Hits 10935 10998 +63
- Misses 1904 1926 +22
- Partials 578 583 +5 ☔ View full report in Codecov by Sentry. |
mykhailo-kuchma
approved these changes
May 27, 2024
rustam-gamidov-here
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take into account that we may detach request and
the fact that data callback may be missing in some cases.
Relates-To: OLPEDGE-2444