Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing hot code allocations #1515

Merged
merged 1 commit into from
May 21, 2024
Merged

Optimizing hot code allocations #1515

merged 1 commit into from
May 21, 2024

Conversation

mykhailo-kuchma
Copy link
Collaborator

Optimize allocations in QuadTreeIndex
Use a stream call API to download blobs to eliminate unnecessary copy

Relates-To: OLPEDGE-2444

@mykhailo-kuchma mykhailo-kuchma force-pushed the task/OLPEDGE-2444 branch 4 times, most recently from 3b9a628 to b2d3cd4 Compare May 20, 2024 13:59
@mykhailo-kuchma mykhailo-kuchma changed the title WIP: optimize allocations Optimize allocations May 21, 2024
@mykhailo-kuchma mykhailo-kuchma changed the title Optimize allocations Optimizing hot code allocations May 21, 2024
@mykhailo-kuchma mykhailo-kuchma force-pushed the task/OLPEDGE-2444 branch 2 times, most recently from cdff9f1 to e0c4e8a Compare May 21, 2024 09:07
Optimize allocations in QuadTreeIndex by using thread local pool
allocator.
Use CallApiStream to download blobs to eliminate unnecessary copy
when using string stream.
Merge ReturnHttpResponseWithDataCallback to ReturnHttpResponse.

Relates-To: OLPEDGE-2444

Signed-off-by: Mykhailo Kuchma <[email protected]>
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 95.31250% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.55%. Comparing base (1fd0778) to head (e0c4e8a).
Report is 1 commits behind head on master.

Files Patch % Lines
...sdk-dataservice-read/src/generated/api/BlobApi.cpp 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1515      +/-   ##
==========================================
+ Coverage   81.54%   81.55%   +0.01%     
==========================================
  Files         342      342              
  Lines       13451    13470      +19     
  Branches     1449     1451       +2     
==========================================
+ Hits        10968    10985      +17     
  Misses       1903     1903              
- Partials      580      582       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mykhailo-kuchma mykhailo-kuchma merged commit d3b0bbb into master May 21, 2024
21 of 22 checks passed
@mykhailo-kuchma mykhailo-kuchma deleted the task/OLPEDGE-2444 branch May 21, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants