Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease number of memory reallocations #1496

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

rustam-gamidov-here
Copy link
Collaborator

Adds dedicated filtering for cases when only tile keys are required by the caller.

Relates-To: MINOR

@rustam-gamidov-here rustam-gamidov-here force-pushed the rga/decrease-number-of-allocations branch from fc309ba to 7f0fd65 Compare April 5, 2024 15:52
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 75.38462% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 81.51%. Comparing base (91d6934) to head (7f0fd65).
Report is 1 commits behind head on master.

❗ Current head 7f0fd65 differs from pull request most recent head 05e3e1c. Consider uploading reports for the commit 05e3e1c to get more accurate results

Files Patch % Lines
...-read/src/repositories/PrefetchTilesRepository.cpp 72.73% 9 Missing and 6 partials ⚠️
...-dataservice-read/src/VersionedLayerClientImpl.cpp 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
- Coverage   81.54%   81.51%   -0.03%     
==========================================
  Files         341      341              
  Lines       13376    13395      +19     
  Branches     1438     1445       +7     
==========================================
+ Hits        10907    10918      +11     
- Misses       1893     1900       +7     
- Partials      576      577       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mykhailo-kuchma
mykhailo-kuchma previously approved these changes Apr 8, 2024
Adds dedicated filtering for cases when only tile keys are required by
the caller.

Relates-To: MINOR
Signed-off-by: Rustam Gamidov <[email protected]>
@rustam-gamidov-here rustam-gamidov-here merged commit e343dc1 into master Apr 22, 2024
17 checks passed
@rustam-gamidov-here rustam-gamidov-here deleted the rga/decrease-number-of-allocations branch April 22, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants