Add support for allowed exception rules in AdBlock format #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces the ability to handle allowed exception rules in AdBlock formatted files. In the AdBlock norm, '@@' at the beginning of the rule means it is an exception. The code is updated to recognize these rules, process them separately, and store them in a new HashSet<string> variable. This will distinguish which Domain Name System (DNS) requests to allow, enhancing the utility's flexibility and control over network traffic rules. The adjustment is accompanied by necessary changes in the tests, improving our project's robustness against future modifications.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
- Coverage 78.40% 76.36% -2.05%
==========================================
Files 7 7
Lines 440 457 +17
Branches 67 71 +4
==========================================
+ Hits 345 349 +4
- Misses 82 95 +13
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update introduces the ability to handle allowed exception rules in AdBlock formatted files. In the AdBlock norm, '@@' at the beginning of the rule means it is an exception. The code is updated to recognize these rules, process them separately, and store them in a new HashSet variable. This will distinguish which Domain Name System (DNS) requests to allow, enhancing the utility's flexibility and control over network traffic rules. The adjustment is accompanied by necessary changes in the tests, improving our project's robustness against future modifications.
PR Type
Fixes Issue(s)