Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/refactor_span_statics #135

Merged
merged 3 commits into from
Oct 16, 2022
Merged

feat/refactor_span_statics #135

merged 3 commits into from
Oct 16, 2022

Conversation

henrikwidlund
Copy link
Owner

Description

  • Use readonly field instead of properties when possible.
  • Use file-scoped namespaces.
  • Simplify some methods.

PR Type

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Unit tests
  • Branch merge
  • Docs
  • Other (please describe in description)

Fixes Issue(s)

@henrikwidlund henrikwidlund added the enhancement New feature or request label Oct 16, 2022
@henrikwidlund henrikwidlund self-assigned this Oct 16, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 78.88% // Head: 78.16% // Decreases project coverage by -0.72% ⚠️

Coverage data is based on head (7e9df47) compared to base (04a7ab0).
Patch coverage: 77.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   78.88%   78.16%   -0.73%     
==========================================
  Files           7        7              
  Lines         431      435       +4     
  Branches       73       72       -1     
==========================================
  Hits          340      340              
- Misses         78       82       +4     
  Partials       13       13              
Flag Coverage Δ
unittests 78.16% <77.57%> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/HostsParser/Program.cs 0.00% <0.00%> (ø)
src/HostsParser/HostUtilities.cs 93.70% <93.18%> (ø)
src/HostsParser/CollectionUtilities.cs 95.19% <94.62%> (+0.09%) ⬆️
src/HostsParser/Settings.cs 97.36% <96.96%> (ø)
src/HostsParser/ProcessingUtilities.cs 98.38% <98.00%> (-0.06%) ⬇️
src/HostsParser/Constants.cs 100.00% <100.00%> (ø)
src/HostsParser/ReadOnlyMemoryCharComparer.cs 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henrikwidlund henrikwidlund changed the title Feat/refactor span statics feat/refactor_span_statics Oct 16, 2022
@henrikwidlund henrikwidlund merged commit 3b54b47 into main Oct 16, 2022
@henrikwidlund henrikwidlund deleted the feat/refactor_span_statics branch October 16, 2022 09:25
github-actions bot added a commit that referenced this pull request Oct 16, 2022
* Specify int value for enums
* Use nameof
* Use ReadOnlyMemory field instead of ReadOnlySpan property.
* Move to file-scoped namespaces 3b54b47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants