-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
40 restore connection #58
Open
KES777
wants to merge
29
commits into
henrikpersson:master
Choose a base branch
from
KES777:40_restore_connection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can 'INSTALL_PREFIX=~/bin ./ssh-copy-rsub [user@]host' to install into home directory
This reverts commit 481059f.
rename: temp_path -> temp_file
This is ROOT temporary working directory
Here we relay on sublime feature when we open same file Also if we open files with same names sublime will distinguish them and pretty show additional directory path on tabs
This reverts commit 481059f.
This reverts commit 481059f.
code was reoranged
Conflicts: ssh-copy-rsub
Conflicts: rsub.py ssh-copy-rsub
…e' into 40_restore_connection
This occour when we edit remote file and plugin was reloaded. After this SESSIONS is empty. So... When we start remote edit iterate all views that related to 'rsub' if it is related bool( env ) and is not in current session (belongs to old disconnected session) not v.id() in SESSIONS and file were opened from same host self.env['host'] == env['host'] and same file were opened self.env['real-path'] == env['real-path'] So we put this view to current session in bring_to_front self.env['work_dir'] = env['work_dir'] SESSIONS[ v.id() ] = self self.temp_file = v.file_name() self.send_save() sublime.active_window().focus_view( v ) bring_to_front() return
Because each session save tmp files in its own random directory we must track where view save its buffer for disconnected session (when plugin were reloaded)
The view can be restored from old session. The old session WORKDIR != current session WORKDIR
When we restore session we must update remote file by local modifications So they will not be lost
This would be very appreciated. |
Due to the slow development of rsub, I am now maintaining a fork of rsub at https://github.com/randy3k/RemoteSubl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves this issue
Please apply only after other my pull requests #54 and #55