Updating useConfigMap & customAgentConfig param desc #21851
Conversation
|
Hi @l0k0ms. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: l0k0ms <[email protected]>
bb91b02
to
815140a
Compare
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clamoriniere, l0k0ms The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: l0k0ms <[email protected]> Signed-off-by: Pierre Gronlier <[email protected]>
| # | ||
| # useConfigMap: false | ||
|
|
||
| ## @param customAgentConfig - object - optional | ||
| ## Specify custom contents for the datadog agent config (datadog.yaml). | ||
| ## ref: https://docs.datadoghq.com/agent/guide/agent-configuration-files/?tab=agentv6 | ||
| ## ref: https://github.com/DataDog/datadog-agent/blob/master/pkg/config/config_template.yaml | ||
| ## Note the `agent.useConfigMap` needs to be set to `true` for this parameter to be taken into account. |
There was a problem hiding this comment.
This needs to be plural agents, right?
Signed-off-by: l0k0ms <[email protected]>
Signed-off-by: l0k0ms <[email protected]>
Signed-off-by: l0k0ms <[email protected]> Signed-off-by: Adrien Loiseau <[email protected]>
Signed-off-by: l0k0ms <[email protected]> Signed-off-by: Miguel Mingorance <[email protected]>
Updates the description of two parameters to make it more obvious that they need to be setup together
It also lint the README file to make it prettier