Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/elastalert]: improve templates - add variables for override fullname of chart #21800

Merged
merged 1 commit into from
Apr 8, 2020
Merged

[stable/elastalert]: improve templates - add variables for override fullname of chart #21800

merged 1 commit into from
Apr 8, 2020

Conversation

bezgubov
Copy link
Contributor

@bezgubov bezgubov commented Apr 6, 2020

Add variables for override fullname of elastalert chart.

@bezgubov-sports
[stable/elastalert]: improve templates - add variables for override f…
730e108 
…ullname of chart

* bump chart

Signed-off-by: Anatoly Bezgubov <[email protected]>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 6, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bezgubov. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 6, 2020
@jertel
Copy link
Collaborator

jertel commented Apr 8, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2020
@jertel
Copy link
Collaborator

jertel commented Apr 8, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bezgubov, jertel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 95de995 into helm:master Apr 8, 2020
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@bezgubov-sports
[stable/elastalert]: improve templates - add variables for override f…
732c91c 
…ullname of chart (helm#21800)

* bump chart

Signed-off-by: Anatoly Bezgubov <[email protected]>

Co-authored-by: Anatoly Bezgubov <[email protected]>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@bezgubov-sports @includerandom
[stable/elastalert]: improve templates - add variables for override f…
e2a10e0 
…ullname of chart (helm#21800)

* bump chart

Signed-off-by: Anatoly Bezgubov <[email protected]>

Co-authored-by: Anatoly Bezgubov <[email protected]>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@bezgubov-sports @li-adrienloiseau
[stable/elastalert]: improve templates - add variables for override f…
0edfc89 
…ullname of chart (helm#21800)

* bump chart

Signed-off-by: Anatoly Bezgubov <[email protected]>

Co-authored-by: Anatoly Bezgubov <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@bezgubov-sports
[stable/elastalert]: improve templates - add variables for override f…
dcf3c9c 
…ullname of chart (helm#21800)

* bump chart

Signed-off-by: Anatoly Bezgubov <[email protected]>

Co-authored-by: Anatoly Bezgubov <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jertel jertel jertel approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bezgubov @k8s-ci-robot @jertel @helm-bot @bezgubov-sports