[stable/grafana]: Only replace variable datasources in shared dashboards #21710
Conversation
|
Hi @languitar. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @zanhsieh |
|
@languitar: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
stable/grafana/Chart.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v1 | |||
| name: grafana | |||
| version: 5.0.10 | |||
| version: 5.0.11 | |||
|
@languitar |
|
@zanhsieh new commit is pushed with an updated version |
|
/ok-to-test |
|
/test pull-charts-e2 |
Avoid replacing hard-coded datasource entries in shared dashboards on downloading them. This is the root causes for #21541, where the following data source is also replace: ```json "annotations": { "list": [ { "builtIn": 1, "datasource": "-- Grafana --", "enable": true, "hide": true, "iconColor": "rgba(0, 211, 255, 1)", "name": "Annotations & Alerts", "type": "dashboard" } ] }, ``` To avoid this situation, this commit adds the requirement that the datasource entry to replace starts with a dollar sign as the first character in the quoted string region. This was the case for all dashboards that I have checked. fixes #21541 Signed-off-by: Johannes Wienke <[email protected]>
|
And once more... |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: languitar, zanhsieh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Avoid replacing hard-coded datasource entries in shared dashboards on downloading them. This is the root causes for helm#21541, where the following data source is also replace: ```json "annotations": { "list": [ { "builtIn": 1, "datasource": "-- Grafana --", "enable": true, "hide": true, "iconColor": "rgba(0, 211, 255, 1)", "name": "Annotations & Alerts", "type": "dashboard" } ] }, ``` To avoid this situation, this commit adds the requirement that the datasource entry to replace starts with a dollar sign as the first character in the quoted string region. This was the case for all dashboards that I have checked. fixes helm#21541 Signed-off-by: Johannes Wienke <[email protected]>
Avoid replacing hard-coded datasource entries in shared dashboards on downloading them. This is the root causes for helm#21541, where the following data source is also replace: ```json "annotations": { "list": [ { "builtIn": 1, "datasource": "-- Grafana --", "enable": true, "hide": true, "iconColor": "rgba(0, 211, 255, 1)", "name": "Annotations & Alerts", "type": "dashboard" } ] }, ``` To avoid this situation, this commit adds the requirement that the datasource entry to replace starts with a dollar sign as the first character in the quoted string region. This was the case for all dashboards that I have checked. fixes helm#21541 Signed-off-by: Johannes Wienke <[email protected]>
Avoid replacing hard-coded datasource entries in shared dashboards on downloading them. This is the root causes for helm#21541, where the following data source is also replace: ```json "annotations": { "list": [ { "builtIn": 1, "datasource": "-- Grafana --", "enable": true, "hide": true, "iconColor": "rgba(0, 211, 255, 1)", "name": "Annotations & Alerts", "type": "dashboard" } ] }, ``` To avoid this situation, this commit adds the requirement that the datasource entry to replace starts with a dollar sign as the first character in the quoted string region. This was the case for all dashboards that I have checked. fixes helm#21541 Signed-off-by: Johannes Wienke <[email protected]> Signed-off-by: Adrien Loiseau <[email protected]>
Avoid replacing hard-coded datasource entries in shared dashboards on downloading them. This is the root causes for helm#21541, where the following data source is also replace: ```json "annotations": { "list": [ { "builtIn": 1, "datasource": "-- Grafana --", "enable": true, "hide": true, "iconColor": "rgba(0, 211, 255, 1)", "name": "Annotations & Alerts", "type": "dashboard" } ] }, ``` To avoid this situation, this commit adds the requirement that the datasource entry to replace starts with a dollar sign as the first character in the quoted string region. This was the case for all dashboards that I have checked. fixes helm#21541 Signed-off-by: Johannes Wienke <[email protected]> Signed-off-by: Miguel Mingorance <[email protected]>
@zanhsieh @rtluckie @maorfr
What this PR does / why we need it:
Avoid replacing hard-coded datasource entries in shared dashboards on
downloading them. This is the root causes for #21541, where the
following data source is also replace:
To avoid this situation, this commit adds the requirement that the
datasource entry to replace starts with a dollar sign as the first
character in the quoted string region. This was the case for all
dashboards that I have checked.
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[stable/mychartname])