Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An improper locking bug(e.g., deadlock) on the lock server #10

Closed
ycaibb opened this issue Sep 9, 2021 · 2 comments
Closed

An improper locking bug(e.g., deadlock) on the lock server #10

ycaibb opened this issue Sep 9, 2021 · 2 comments

Comments

@ycaibb
Copy link

ycaibb commented Sep 9, 2021

Hi, developers, thank you for your checking. I found a possible bug in UltraGrid, which locates in EmbeddableWebServer.
It seems the lock server is not released correctly when !server->initialize in the function serverStop?

https://github.com/CESNET/UltraGrid/blob/e3c926c8ff67586bf74c4cc0763a78c83ede9cf6/src/EmbeddableWebServer.h#L1515-L1526
Can you confirm this?

The original issue:
CESNET/UltraGrid#183

@ycaibb ycaibb closed this as completed Sep 9, 2021
@ycaibb
Copy link
Author

ycaibb commented Sep 9, 2021

My problem has been resolved.

@hellerf
Copy link
Owner

hellerf commented Sep 9, 2021

Oh that certainly does look extremely suspicious! Thank you for reporting it

hellerf added a commit that referenced this issue Sep 9, 2021
…ks. Thanks to ycaibb for reporting! Although this was not their actual issue, it should still be fixed.

#10
hellerf added a commit that referenced this issue Sep 9, 2021
…ks. Thanks to ycaibb for reporting! Although this was not their actual issue, it should still be fixed.

#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants