Fix system clipboard with mosh + tmux #9834
Conversation
useche
force-pushed
the
osc52_tmux_passthrough
branch
from
d17f96b
to
c25ab35
Compare
the-mikedavis
added
the
S-waiting-on-review
useche
force-pushed
the
osc52_tmux_passthrough
branch
from
c25ab35
to
9f9f6af
Compare
useche
changed the title
|
Doesn't this code make helix coupled to tmux specifically and only fix tmux rather than the special issue of any wrapper app not passing clipboard through? |
Hi! This patch makes Helix as coupled to tmux as it has been in the past (helix already checks if it's currently inside tmux to make decisions about how to setup the clipboard). The only difference is that apart from checking if it is inside tmux, it also checks if some particular feature of tmux is enabled to use it.
I'm not sure what you mean here. Helix already has OSC52 support as fallback mechanism is no other was found suitable. From the question it sounds like you were looking to add an option to the config file to force OSC52? I thought about this one too, but I've seen reluctance in adding new options to Helix config and realized that the decision could be automated this way. |
|
@useche Yes that's what I meant about enabling when wanted, ans thank you for the explanations I didn't know about the existing checks targeting tmux 👍 |
helix-view/src/clipboard.rs
Outdated
| } else if tmux_allow_passthrough() { | ||
| // If we are in tmux and it allows passthrough, lets use OSC52 and escape tmux. | ||
| Box::new(provider::FallbackProvider::new()) | ||
| } else if env_var_is_set("TMUX") && binary_exists("tmux") { |
There was a problem hiding this comment.
Why is this a separate branch rather than nesting under the next one that's already checking for tmux?
There was a problem hiding this comment.
I don't know why I did that. I combined the the two branches.
| if !env_var_is_set("TMUX") { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Then this check would be redundant
There was a problem hiding this comment.
We still need this check. The reason is that this function is also used in the OSC52 fallback, which won't necessarily be used with tmux. So, to escape OSC52 string through tmux, we still need to check if we are in tmux and whether the feature is on or not.
useche
force-pushed
the
osc52_tmux_passthrough
branch
3 times, most recently
from
190202e
to
6a9b791
Compare
|
I added documentation for a better explanation of the feature and how to enable it. |
Some times tmux doesn't pass the clipboard information to the terminal correctly. This is the case of mosh + tmux. The current clipboard doesn't work properly in this case. However, when the tmux option `allow-passthrough` is on, we can escape tmux and pass the OSC52 string directly to the terminal. In this patch, if helix detects that tmux `allow-passthrough` is on, it will use the OSC52 clipboard provider and will escape tmux and pass the OSC52 directly to the terminal. Tested with mosh + tmux with the `allow-passthrough` option on.
useche
force-pushed
the
osc52_tmux_passthrough
branch
from
6a9b791
to
81687f2
Compare
Some times tmux doesn't pass the clipboard information to the terminal correctly. One example of this is mosh + tmux. In this case the current clipboard doesn't work properly. However, when the tmux option
allow-passthroughis on, we can escape tmux and pass the OSC52 string directly to the terminal.In this patch, if helix detects that tmux
allow-passthroughis on, it will use the OSC52 clipboard provider and will escape tmux and pass the OSC52 directly to the terminal.Tested with mosh + tmux with the
allow-passthroughoption on.