Make the spinner spin when the LSP doen't sent progress report #9787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spinner also keep the current annimation frame idx so, if it is stopped and restart then the animation is smoother.
the-mikedavis
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposition to make the spinner more smooth (#8704).
I understand that efficiency is important for Helix (#6446 (comment)) and I fully agree with that. What I propose is to automatically redraw the view every 100ms if there are a lsp job in progress. So ether:
When the lsp job is completed there should be no overhead.
For a quick "benchmark" on my average pc when opening helix project I see currently 70 calls to terminal::draw vs 123 calls using the auto redraw. After that the number of draw calls are the same.