Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle spaces in filenames in bash autocomplete #9702

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Properly handle spaces in filenames in bash autocomplete #9702

merged 1 commit into from
Feb 23, 2024

Conversation

wr7
Copy link
Contributor

@wr7 wr7 commented Feb 22, 2024 •
edited by the-mikedavis
Loading

Fixes #9701.

@the-mikedavis the-mikedavis added the S-waiting-on-review Status: Awaiting review from a maintainer. label Feb 23, 2024
the-mikedavis
the-mikedavis approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pascalkuthe pascalkuthe merged commit 7100ed4 into helix-editor:master Feb 23, 2024
6 checks passed
@wr7 wr7 deleted the fix-bash-autocomplete branch February 23, 2024 16:09
@wr7 wr7 restored the fix-bash-autocomplete branch February 23, 2024 16:10
@wr7 wr7 deleted the fix-bash-autocomplete branch February 23, 2024 16:10
@wr7 wr7 mentioned this pull request Feb 23, 2024
Merged
uek-1 pushed a commit to uek-1/helix that referenced this pull request Feb 24, 2024
@wr7 @uek-1
Properly handle spaces in filenames in bash autocomplete (helix-edito…
05cd8b2 
…r#9702)
ofzo pushed a commit to ofzo/helix-editor that referenced this pull request Feb 26, 2024
@wr7 @ofzo
Properly handle spaces in filenames in bash autocomplete (helix-edito…
af0553f 
…r#9702)
shortc pushed a commit to shortc/helix that referenced this pull request Mar 31, 2024
@wr7 @chrisshort-udig
Properly handle spaces in filenames in bash autocomplete (helix-edito…
ef8635b 
…r#9702)
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@wr7 @postsolar
Properly handle spaces in filenames in bash autocomplete (helix-edito…
46f80f8 
…r#9702)
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@wr7 @mtoohey31
Properly handle spaces in filenames in bash autocomplete (helix-edito…
b66ed8c 
…r#9702)
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@wr7 @Vulpesx
Properly handle spaces in filenames in bash autocomplete (helix-edito…
7a6db8e 
…r#9702)
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@wr7
Properly handle spaces in filenames in bash autocomplete (helix-edito…
f210345 
…r#9702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hx bash autocomplete does not properly handle file names/paths with spaces
3 participants
@wr7 @the-mikedavis @pascalkuthe