Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve statusline #916

Merged
merged 8 commits into from
Oct 27, 2021
Merged

Improve statusline #916

merged 8 commits into from
Oct 27, 2021

Conversation

Omnikar
Copy link
Contributor

@Omnikar Omnikar commented Oct 26, 2021

Discussed on Matrix with @archseer.

I haven't worked with this part of the codebase before, so I don't know whether I used the things I did correctly.

* Change diagnostic count display to show counts of individual
  diagnostic types next to their corresponding gutter dots.
* Add selection count to the statusline.
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I tested it locally and I quite like it. Just some minor comments

helix-term/src/ui/editor.rs Outdated Show resolved Hide resolved
helix-term/src/ui/editor.rs Outdated Show resolved Hide resolved
helix-term/src/ui/editor.rs Outdated Show resolved Hide resolved
helix-term/src/ui/editor.rs Outdated Show resolved Hide resolved
helix-term/src/ui/editor.rs Outdated Show resolved Hide resolved
helix-term/src/ui/editor.rs Outdated Show resolved Hide resolved
@Omnikar Omnikar requested a review from archseer October 27, 2021 02:04
@archseer archseer merged commit 2505802 into helix-editor:master Oct 27, 2021
@Omnikar Omnikar deleted the statusline branch October 27, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants