Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword on goto_change shortcut keys #8494

Closed

Conversation

hongquan
Copy link

@hongquan hongquan commented Oct 9, 2023

The old wording is confusing.

@leandrobbraga
Copy link

leandrobbraga commented Oct 9, 2023

I do believe that the idea of the previous naming is to be VCS agnostic, change seems a little bit too vague, but I can't think in a better name right now to suggest

@hongquan
Copy link
Author

hongquan commented Oct 9, 2023

At first, I didn't understand what it means, until I found the blog post about Helix's Git support.
I think, in the future, when Helix supports more VCS, it can be named "Goto VCS change/hunk". For now, Helix only supports Git and it is more obvious to say "Go to Git hunk".

Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • we plan to support other VCS in the future (as plugins) so Git should not be mentioned explicitly
  • we will allow diffing against arbitrary files and Buffets (a PR is already open) so it should not mention VCS either

These were designed goals from the start which is why I chose the current description. The most I would co sidereal is to use diff change instead of change.

These also aren't the rendered docs. Those should be adjusted to match

@hongquan
Copy link
Author

Thanks. I will close this PR and wait for Helix update.

@hongquan hongquan closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants