Global search now indicates currently open document #803
Conversation
|
Thanks for contributing to helix. Looks like a good feature to have but I think |
|
Hi! I chose |
|
Please keep them as is, but can you rebase on top of master? There was a lint failure that has been addressed. |
|
Whoops - I didn't attach a pic of the buffer picker: I've merged upstream/master and pushed those! Thanks for the info. |
| @@ -1291,7 +1291,8 @@ fn global_search(cx: &mut Context) { | |||
|
|
|||
| cx.push_layer(Box::new(prompt)); | |||
|
|
|||
| let root = find_root(None).unwrap_or_else(|| PathBuf::from("./")); | |||
| let current_path = doc_mut!(cx.editor).path().cloned(); | |||
There was a problem hiding this comment.
Actually, this keeps the path relative to the working directory whereas other pickers use the project root. Can we keep the original behavior? Either that or other code paths should be updated to align the behaviors.
There was a problem hiding this comment.
Hmm, I'm not sure I understand. That current_path variable is just used to compare against the list of search results for when to put in the asterisk. It doesn't change where the path is relative to.
I'm not sure what you mean by working directory vs project root. I attempted to use the same logic which the buffer_picker used when formatting relative path: helix_core::path::get_relative_path(path)
There was a problem hiding this comment.
Looks like buffer_picker and file_picker don't use the same logic. I'll fix it in a follow-up.
So I guess I also implemented the global search relative file paths slightly after someone else. I decided to add the
(*)like the buffer picker indicates the currently open document.