Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readonly status #7740

Merged
merged 29 commits into from
Aug 8, 2023
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
7fa7896
ignore runtime symlink
connortsui20 Jul 25, 2023
4e01088
added is_read_only and "[readonly]" to statusline
connortsui20 Jul 26, 2023
141a162
change to check if readonly on set_path()
connortsui20 Jul 26, 2023
d17992c
undo first commit gitignore mess up
connortsui20 Jul 27, 2023
407959d
change Document readonly field to bool
connortsui20 Jul 27, 2023
4696692
readonly check on write_impl and write_all_impl
connortsui20 Jul 29, 2023
6ad36ba
add readonly indicator element on statusline
connortsui20 Jul 29, 2023
9b4010d
use access syscall for unix readonly
connortsui20 Jul 29, 2023
0059cce
spacing corrected for statusline text
connortsui20 Jul 29, 2023
d23252e
delete runtime
connortsui20 Jul 29, 2023
e01f1e7
Add todo message for windows readonly
connortsui20 Jul 29, 2023
7ecaf74
added error list of readonly files on write-all
connortsui20 Jul 29, 2023
dfa11dc
shorthand change back
connortsui20 Jul 30, 2023
0700254
clearer readonly message
connortsui20 Jul 30, 2023
7f18081
change rustix dep for unix only
connortsui20 Jul 30, 2023
d593548
add read-only-indicator to docs
connortsui20 Jul 30, 2023
d9faba8
added back newline to .gitignore
connortsui20 Jul 30, 2023
c2361a4
change spacing on no file modification
connortsui20 Jul 30, 2023
5cd5baa
change detect_readonly() for windows compilation
connortsui20 Jul 30, 2023
c048345
reorder default statusline
connortsui20 Jul 30, 2023
48600f5
remove extra spaces
connortsui20 Jul 30, 2023
bbcbdfe
simplicity and comment fixes
connortsui20 Aug 4, 2023
f54f2f3
remove force checks
connortsui20 Aug 4, 2023
9bcde99
removed dead code
connortsui20 Aug 4, 2023
bbe6ccd
removed more dead code
connortsui20 Aug 4, 2023
6088449
better description
connortsui20 Aug 4, 2023
1b55179
fix lint
connortsui20 Aug 5, 2023
3c9ba32
revert to static str
connortsui20 Aug 8, 2023
04f9a57
revert whole function
connortsui20 Aug 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed more dead code
  • Loading branch information
connortsui20 committed Aug 4, 2023
commit bbe6ccd44ef5292b92f363d25c6ef1b078a13018
6 changes: 0 additions & 6 deletions helix-term/src/commands/typed.rs
Original file line number Diff line number Diff line change
Expand Up @@ -725,12 +725,6 @@ pub fn write_all_impl(
}

let error_msg = errors.join(" ");
// if !readonly_errors.is_empty() {
// // statusline text will have the form:
// // [/home/user/readonly.txt is readonly, ..., /readonly2.txt is readonly] add ! to overwrite
// error_msg = format!("{:?} use ! to overwrite", readonly_errors).replace('"', "");
// }

if !error_msg.is_empty() {
bail!(error_msg);
}
Expand Down