Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedicated mode for sticky and debug #7632

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Dedicated mode for sticky and debug #7632

wants to merge 2 commits into from

Conversation

Marsevil
Copy link

@Marsevil Marsevil commented Jul 14, 2023 •
edited
Loading

Fix #5951

  • Rework sticky mode
  • Rework debug mode

@Marsevil
refactor(ui): Adding view mode
7355f26 
Replace sticky mode by a dedicated *view* mode.
@Marsevil
refactor(ui): Show commands for view mode
f0a0d48 
Re-enable showing commands in view mode
the-mikedavis
the-mikedavis requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding items to the mode enum is not the direction we want to go: #5951 (comment)

@pascalkuthe pascalkuthe added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 15, 2023
@Marsevil
Copy link
Author

That way, I don't understand this one #5951 (comment)
May we want something like "submodes" which are trait object and so add keybinds and so on ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DBG (Debug) editor mode
3 participants
@Marsevil @the-mikedavis @pascalkuthe