match against unix file path [windows] (#5414) #6564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a change to the Atom, whereby '/' are replace with '\' on Windows. This allows the user to type in unix style paths and have it successfully match against Windows file paths. I would have preferred to handle this in the matching logic, however the fuzzy match api doesn't seem to offer a way to say "treat A like B". Signed-off-by: Jack Mordaunt <[email protected]>
91d36b4
to
71b9da4
Compare
pascalkuthe
requested changes
Apr 26, 2023
|
Also for consistency might as well display the paths with forward slashes in file picker/search result picker. |
|
going to close this one out as the picker has been rewritten since this one was made. I also don't see us going forward with this approach. Thank you fro contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a change to the Atom, whereby '/' are replace with '\' on Windows. This allows the user to type in unix style paths and have it successfully match against Windows file paths.
Fixes #5414
demo.out.mp4