Update Bass grammar and queries #6547
Conversation
|
Marking as draft; noticed a minor thing to fix in the grammar (expanding allowed characters in paths), will reopen when it's ready. |
|
Path parsing fix is in, good to go now 👍 |
| (path) @string.special.path | ||
| (command) @string.special.path | ||
|
|
||
| (number) @constant.numeric.integer |
There was a problem hiding this comment.
Does number capture integers and floats? @constant.numeric would be more appropriate if it is both but the current capture is good if it's just integers
|
|
||
| ;; Comments | ||
|
|
||
| (comment) @comment.line @spell |
There was a problem hiding this comment.
| (comment) @comment.line @spell | |
| (comment) @comment |
|
|
||
| [ | ||
| "^" | ||
| ] @character.special |
There was a problem hiding this comment.
| ] @character.special | |
| ] @string.special |
There was a problem hiding this comment.
It looks like these are in the neovim format. We use different captures for indentation queries: https://docs.helix-editor.com/master/guides/indent.html
| @@ -0,0 +1 @@ | |||
| (comment) @comment | |||
There was a problem hiding this comment.
Similar here about injections
| (comment) @comment | |
| ((comment) @injection.content | |
| (#set! injection.language "comment")) |
There was a problem hiding this comment.
We follow tree-sitter for locals captures but these are in nvim's format. See https://tree-sitter.github.io/tree-sitter/syntax-highlighting#local-variables
@scope should become @local.scope while @reference becomes @local.reference and the two @definition... captures become @local.definition
pascalkuthe
added
S-waiting-on-author
Hiya, this is a follow-up to #3771 that bumps to the latest grammar (now rewritten by @amaanq 🙏), updates the highlight rules, and adds a few more queries:
folds.scmindents.scminjections.scmlocals.scmTested locally on my machine and all seems well.