-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add better default breakpoint icon #6188
base: master
Are you sure you want to change the base?
Enhancement: Add better default breakpoint icon #6188
Conversation
That just looks like a regular error now. I thought we picked a different icon? I can't find the thread right now |
Duplicate of #5957 which includes an improved icon and a new highlight scope plus theme adjuatement. See #5957 (comment) for what thus looks like |
I meant adding NerdFont icons such as making use of #2869, which would look a bit better than the current ones in #5957. What you did is a duplicate of my work, as @pascalkuthe and @archseer mentioned. |
@archseer @filipdutescu whoops sorry about that! I definitely misunderstood. The flow of the conversation was a bit confusing between the two issues. |
the bug looks a bit noisy to me. For specical breakpoints (condition, log, data, function,...) there are already icons: I am not sure what a data breakpoint is supposed to be so we could just use that icon for normal breakpoints. Alternatively just the various nerdfont cricels seem like a good option: |
Thanks for the feedback!
We don't have those codified yet, I'll add those icons in and update the logic in the function that determines the icon for the breakpoint.
Yeah, I agree. I'll use the regular filled circle for the normal breakpoints. |
Stack frame one is exactly the kind of icon I had in mind adding the task. Great catch! Also the stackframe with breakpoint in it for when you have a breakpoint on the current line is perfect |
…load_toml` from theme.rs to the `helix-loader` module
…r::read_toml_names`
…better_breakpoint_icon
509d87d
to
5cd2a4e
Compare
the breakpoint struct has |
I would say that conditional breakpoints take precedence. To me it is very important to know when/if a breakpoint will be hit, to plan how my debugging session should go. |
Summary
closes #5956
In #5952 @archseer and @filipdutescu suggested to use the same icon being used by the diagnostics for breakpoints. I also updated the default color to use the
error
color set by the UI theme.EDIT:
Built on top of #2869