Integration test helper improvements #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dead10ck
force-pushed
the
integration-test-improve
branch
from
ec3ff23
to
9c77e34
Compare
pascalkuthe
added
the
S-waiting-on-review
dead10ck
force-pushed
the
integration-test-improve
branch
from
9c77e34
to
53adf91
Compare
dead10ck
force-pushed
the
integration-test-improve
branch
3 times, most recently
from
3feb2a2
to
f19fb10
Compare
archseer
previously approved these changes
Mar 16, 2023
dead10ck
force-pushed
the
integration-test-improve
branch
from
f19fb10
to
779234e
Compare
|
Done 🙂 |
The current test DSL currently has no way to express being at the end of a line, save for putting an explicit LF or CRLF inside the `#[|]#`. The problem with this approach is that it can add unintended extra new lines if used in conjunction with raw strings, which insert newlines for you. This is a simple attempt to mitigate this problem. If there is an explicit newline character at the end of the selection, and then it is immediately followed by the same newline character at the right end of the selection, this following newline is removed. This way, one can express a cursor at the end of a line explicitly.
test::plain uses char indices when it should use byte indices
dead10ck
force-pushed
the
integration-test-improve
branch
from
779234e
to
01c5382
Compare
the-mikedavis
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reorganize write command tests to their own module
make
TestCase::Frommore generic for ergonomicsprint doc state during tests for much better debugging
To help with ergonomics,
test::printwas changed to allow explicit newlines in test DSL. The current test DSL currently has no way to express being at the end of a line, save for putting an explicit LF or CRLF inside the#[|]#. The problem with this approach is that it can add unintended extra new lines if used in conjunction with raw strings, which insert newlines for you.This is a simple attempt to mitigate this problem. If there is an explicit newline character at the end of the selection, and then it is immediately followed by the same newline character at the right end of the selection, this following newline is removed. This way, one can express a cursor at the end of a line explicitly.
fix a bug
test::plain: it is currently using char indices forString::insert_strwhich is supposed to take byte indices. This causes panics on Unicode charactersuse
AppBuildermore consistently throughout tests to make use of saner defaults and improve readability