Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logo for contrib icon #4982

Merged
merged 1 commit into from
Dec 4, 2022

Conversation

the-mikedavis
Copy link
Member

#4971 (comment)

This is the icon used in the .desktop entry

@the-mikedavis the-mikedavis added the A-packaging Area: Packaging and bundling label Dec 3, 2022
@archseer
Copy link
Member

archseer commented Dec 3, 2022

Should we size it as 512x512? It's at an odd size right now

@David-Else
Copy link
Contributor

I can't seem to find a definitive guide to choosing desktop icon sizes, but I think 256 x 256 is the standard for Gnome at least: https://developer.gnome.org/documentation/tutorials/themed-icons.html

Other sizes are optional, but a 256×256 icon is the default size used by GNOME in its application grid, so you’re strongly encouraged to provide one.

Reaper only provides a 256 x 256 icon, and I am sure they are trying to follow standards as closely as possible:

Screenshot from 2022-12-03 08-29-38

As the Helix desktop icon here has no installer at the moment (that I know about, but I have only installed from source) it is up to the user to deal with the icon, to be future proof you might want to provide it in the following standard config, here is the OBS studio flatpak:

icons
└── hicolor
    ├── scalable
    │   └── apps
    │       └── com.obsproject.Studio.svg
    ├── 512x512
    │   └── apps
    │       └── com.obsproject.Studio.png
    ├── 256x256
    │   └── apps
    │       └── com.obsproject.Studio.png
    └── 128x128
        └── apps
            └── com.obsproject.Studio.png

Some apps provide 16x16, 64x64 etc, but I don't think there is any need for that. There is probably no need to do anything other than resize it to 256 x 256 at this point?

@the-mikedavis
Copy link
Member Author

Downscaled it to 256x256 👍

@archseer archseer merged commit c13c6d5 into helix-editor:master Dec 4, 2022
@the-mikedavis the-mikedavis deleted the md-contrib-icon branch December 4, 2022 02:13
herkhinah pushed a commit to herkhinah/helix that referenced this pull request Dec 11, 2022
freqmod pushed a commit to freqmod/helix that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-packaging Area: Packaging and bundling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants