Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transparent theme based on base16_default #3216

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

GreasySlug
Copy link
Contributor

related #3059
discussions #3142
It was created based on the base16_default theme, and matches especially dark images.
The drawback is that the background is all transparent, making it hard to see pop-ups.
The pop-up background can be black for better visibility, but I don't do that.

@the-mikedavis the-mikedavis self-requested a review July 27, 2022 15:02
@the-mikedavis
Copy link
Member

You may want to add a ui.cursorline.primary and maybe a ui.cursorline.secondary theme for cursorline. Otherwise this looks good to me 👍

@the-mikedavis
Copy link
Member

Did you mean to update the ui.cursor and not ui.cursorline scopes in that commit? Not defining cursorline is ok if it wouldn't look good in the theme anyways but it's worth giving it a try even if you won't use the feature

@GreasySlug
Copy link
Contributor Author

GreasySlug commented Jul 28, 2022

Oh, sorry, I took mistook cursorline for cursor.
However, I tried to add them, but the default colors were inevitably too intense, so I gave up adding them.
I would like to add them when I can change the transparency in helix.

@the-mikedavis
Copy link
Member

I don't think real transparency is possible because of terminal limitations, although there is similar work like dimming #2751

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎨

Could you add a screenshot to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

@the-mikedavis the-mikedavis merged commit 14eca31 into helix-editor:master Jul 28, 2022
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants