Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic dimming functionality #2751

Closed
wants to merge 12 commits into from
Closed

Add basic dimming functionality #2751

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8d367d9
adds basic dimming functionality
farwyler Jun 11, 2022
f6d9376
fix clippy lint issue
farwyler Jun 11, 2022
68d76a2
simplifys implementation & removes palette dependency.
farwyler Jun 14, 2022
449ce13
adds dimming documentation
farwyler Jun 14, 2022
273e609
don't dim behind child content
farwyler Jun 14, 2022
ccbd0d7
Update helix-tui/src/buffer.rs
farwyler Jun 17, 2022
e6ac344
expand alpha range for new shade function
farwyler Jun 17, 2022
764540f
removes caching in dim function
farwyler Jun 17, 2022
08bf7bd
remove unnecessary derives from color
farwyler Jun 17, 2022
52b9065
remove unused imports
farwyler Jun 17, 2022
a94db20
Update helix-tui/src/buffer.rs
farwyler Jun 20, 2022
bb4fec7
implements ad hoc dimming
farwyler Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't dim behind child content
  • Loading branch information
@farwyler
farwyler committed Jul 2, 2022
commit 273e60944b1370d469d90a585613c5725e2a4636
22 changes: 19 additions & 3 deletions helix-term/src/ui/overlay.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,27 @@ fn clip_rect_relative(rect: Rect, percent_horizontal: u8, percent_vertical: u8)

impl<T: Component + 'static> Component for Overlay<T> {
fn render(&mut self, area: Rect, frame: &mut Buffer, ctx: &mut Context) {
let dimensions = (self.calc_child_size)(area);
if let Some(shade) = ctx.editor.config().dim.overlay_backdrops {
// TODO: optimise. we don't need to dim behind the child content
frame.dim(area, shade);
frame.dim(area.clip_left(dimensions.right()), shade);
frame.dim(area.with_width(dimensions.left()), shade);
frame.dim(
Rect {
y: 0,
height: dimensions.y,
..dimensions
},
shade,
);
frame.dim(
Rect {
y: dimensions.bottom(),
height: area.height - dimensions.bottom(),
..dimensions
},
shade,
);
}
let dimensions = (self.calc_child_size)(area);
self.content.render(dimensions, frame, ctx)
}

Expand Down