Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme key for picker separator #2523

Merged
merged 1 commit into from
May 22, 2022
Merged

Conversation

kyrime
Copy link
Contributor

@kyrime kyrime commented May 20, 2022

Addresses #2522.

I'm unsure what the most proper name/scope for the theme key is. I've chosen ui.background.separator as ui.background is the style used for widget borders so the scope should draw a reasonable default for all themes.

@the-mikedavis the-mikedavis linked an issue May 20, 2022 that may be closed by this pull request
@the-mikedavis the-mikedavis added the S-waiting-on-review Status: Awaiting review from a maintainer. label May 20, 2022
@archseer archseer merged commit bfc4ff4 into helix-editor:master May 22, 2022
@kyrime kyrime deleted the picker-sep branch May 23, 2022 10:38
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picker separator below input line lacks a theme key
3 participants