Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gruvbox themes #11477

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Update gruvbox themes #11477

merged 1 commit into from
Aug 19, 2024

Conversation

0rphee
Copy link
Contributor

@0rphee 0rphee commented Aug 13, 2024

  • stylize v2 picker column headers

Doing the same as #11459

@the-mikedavis
Copy link
Member

Are you running a Helix version behind the latest master? We changed the way these keys work in #11343 so this looks like

1

rather than what you posted in #11459 (comment)

To make the header look like that column you can switch the key to be "ui.picker.header.column".

You might also want to consider setting the active header ("ui.picker.header.column.active") which indicates which column you're currently typing into. For example in my theme I have

"ui.picker.header.column" = { underline.style = "line" }
"ui.picker.header.column.active" = { fg = "fg0", modifiers = ["bold"], underline.style = "line" }

2

@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Aug 13, 2024
@0rphee
Copy link
Contributor Author

0rphee commented Aug 14, 2024

Hmm, I'm a little confused, because it looks like this to me:

Screenshot 2024-08-14 at 10 17 46 a m

This is after rebasing on the latest master...

@the-mikedavis
Copy link
Member

What's your hx --version output and which terminal emulator are you using?

* stylize v2 picker column headers
@0rphee
Copy link
Contributor Author

0rphee commented Aug 17, 2024

Oh, I'm so sorry, I forgot to actually use the newest version, and not just change the themes...

I was aiming at what you said in #11477 (comment). I've updated the changes to align with what you suggested. Thanks.

@the-mikedavis the-mikedavis merged commit 9e7c488 into helix-editor:master Aug 19, 2024
6 checks passed
diucicd pushed a commit to diucicd/helix that referenced this pull request Aug 20, 2024
kyruzic pushed a commit to kyruzic/helix that referenced this pull request Sep 27, 2024
plul pushed a commit to plul/helix that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants