Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent :move overwriting destination & Add :move! to force overwrite #11093

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

5-pebbles
Copy link

@5-pebbles 5-pebbles commented Jul 5, 2024

If you run the old :move command with a path that already exists, that file will be overwritten without warning.

Example:

echo "hello world" > a
echo "bye world" > b

hx b
# the run: `:move a`

cat a
# output: bye world

In this PR moving to an existing destination will display the following: Destination exists. Use `:move!` to overwrite.

I have also added the :move! command which behaves the same as the old move, overwriting the destination.

@5-pebbles
Copy link
Author

I finally tried to look into this, and I can't reproduce the github actions error.

@5-pebbles
Copy link
Author

5-pebbles commented Aug 18, 2024

I don't understand what the problem is... 5-pebbles#3 it works fine on my fork.
I assume it has something to do with caching, but I will look into github actions further this week.

@the-mikedavis
Copy link
Member

master might've been broken when you last merged with it. You can merge with master again and see if that fixes the CI

@5-pebbles
Copy link
Author

master might've been broken when you last merged with it. You can merge with master again and see if that fixes the CI

Um, I did not think that was the issue... Thank you very much for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command Area: Commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants