Document completion menu bindings #10994
Open
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
book/src/keymap.md
Outdated
| | ---- | ----------- | | ||
| | `Shift-Tab`, `Ctrl-p`, `Up` | Previous entry | | ||
| | `Tab`, `Ctrl-n`, `Down` | Next entry | | ||
| | `Escape` | Close menu and accept completion | |
There was a problem hiding this comment.
The behavior is a little nuanced for escape - it's not directly handled by completion. It's actually ignored by completion and anything ignored by completion (arrow keys for example) cause the completion to be accepted. We may want to remove this from the table here and then have a blurb below that says that anything other than what's in the table causes the completion item to be accepted.
| | `Shift-Tab`, `Ctrl-p`, `Up` | Previous entry | | ||
| | `Tab`, `Ctrl-n`, `Down` | Next entry | | ||
| | `Escape` | Close menu and accept completion | | ||
| | `Ctrl-c` | Close menu and reject completion | |
There was a problem hiding this comment.
The only other one that's special cased I believe is Enter which just accepts the completion item
|
Addressed feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document bindings discussed in #10976