add "goto next workspace diagnostic" commands #10913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds - goto_next_diag_workspace - goto_next_error_workspace - goto_next_warning_workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helix currently has commands to go to the next LSP diagnostic in the present document, and it has a picker for workspace diagnostics and the ability to show in the status bar the number of workspace errors and warnings, but it lacks a seemingly simple "goto next workspace diagnostic" command.
This PR adds
goto_next_diag_workspace(any diagnostic level)goto_next_error_workspace(errors)goto_next_warning_workspace(errors and warnings)Addition of
goto_prev_...,goto_first_...andgoto_last_...commands to match the existing ones that only search the current document I think are less important (the ones I personally want are almost always thegoto_next_...variants), but should be easy to add as a follow up PR if the structure of this one is accepted.Discussion of default keybindings for these commands should be reserved for a separate PR.
I'm a first time contributor to Helix, so bear that in mind when reviewing. Some helper functions I wasn't sure in which module to best place them. But any feedback or push back is welcomed.
Some related issues/pull-requests:
goto_next_diag_error/goto_prev_diag_error#3405