Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to control overtype of closing pairs #10878

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

verte-zerg
Copy link

Changes:

  • added new option auto-closing-overtype to control overtype of closing pairs (default: true)
  • updated documentation

Closes: #9595

I've implemented the feature and only then realized that another PR, which is fixing the issue, already exists. However, it looks like there have been no changes for a month.

The PR doesn't break compatibility with old configs.

@verte-zerg verte-zerg changed the title Automatic option to control overtype of closing pairs Add option to control overtype of closing pairs Jun 4, 2024
@dlordi
Copy link

dlordi commented Jun 12, 2024

Hi, I basically implemented this same solution when I found your PR.
Just a couple of differences:

  • naming the new option auto-pairs-overtype could help consistency
  • swapping the order of tests in next_char == Some(pair.close) && auto_closing_overtype should slightly improve perfomance when this option is off

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to not overtype on closing pairs
3 participants