Add completion/signature bindings to keymap.md #10654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR helix-editor#9974 added alt-p/alt-n keybindings to scroll through signatures. This wasn't very discoverable, as it's not in the docs or the command palette. This also removes a broken link for "comment mode" in the table of contents.
book/src/keymap.md
Outdated
Comment on lines
16
to
17
| - [Completion Popup](#completion-popup) | ||
| - [Signature Popup](#signature-popup) |
There was a problem hiding this comment.
For naming let's call these the "Completion Menu" and "Signature-help Popup"
| @@ -12,8 +12,9 @@ | |||
| - [Match mode](#match-mode) | |||
| - [Window mode](#window-mode) | |||
| - [Space mode](#space-mode) | |||
| - [Comment mode](#comment-mode) | |||
There was a problem hiding this comment.
I think this might be an artifact of #4718, IIRC that originally had a comment mode under space mode. Should be safe to remove 👍
the-mikedavis
approved these changes
May 2, 2024
pascalkuthe
approved these changes
May 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
* Add completion/signature bindings to keymap.md PR helix-editor#9974 added alt-p/alt-n keybindings to scroll through signatures. This wasn't very discoverable, as it's not in the docs or the command palette. This also removes a broken link for "comment mode" in the table of contents. * Update keymap.md
Chirikumbrah
pushed a commit
to Chirikumbrah/helix
that referenced
this pull request
Jun 15, 2024
* Add completion/signature bindings to keymap.md PR helix-editor#9974 added alt-p/alt-n keybindings to scroll through signatures. This wasn't very discoverable, as it's not in the docs or the command palette. This also removes a broken link for "comment mode" in the table of contents. * Update keymap.md
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* Add completion/signature bindings to keymap.md PR helix-editor#9974 added alt-p/alt-n keybindings to scroll through signatures. This wasn't very discoverable, as it's not in the docs or the command palette. This also removes a broken link for "comment mode" in the table of contents. * Update keymap.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9974 added alt-p/alt-n keybindings to scroll through signatures. This wasn't very discoverable, as it's not in the docs or the command palette.
This also removes a broken link for "comment mode" in the table of contents.