Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color theme ao #10617

Closed
wants to merge 18 commits into from
Closed

Color theme ao #10617

wants to merge 18 commits into from

Conversation

YardQuit
Copy link
Contributor

Formulated a dark color scheme evoking the essence of Fedora Linux, incorporating hues of blue reminiscent of the brand's identity.

YardQuit and others added 16 commits April 13, 2024 13:39
Add virtual jump label theme setting
update storage. keyword.storage. according to suggestion, and update color.
remove unused palette
add missing setting for bufferline
update diagnostic fg color
I made the config more comprehensive and took all available themes settings from the manual. Some are commented out though.
add missing colors
fix typos
runtime/themes/ao.toml Outdated Show resolved Hide resolved
commented out settings that should fallback to its more general setting.
remove redundant settings
@kirawi kirawi added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels May 11, 2024
@YardQuit
Copy link
Contributor Author

Sorry for my ignorance in merge requests, but is there anything else expected from my end?
Same question goes for #10381

@the-mikedavis
Copy link
Member

#10381 is waiting on a second reviewer to approve. It looks like this PR contains the changes in #10381 though so I've been waiting for #10381 to be merged to review this one. If you can separate the changes I'll review it independently. Or we could close #10381 and say that this PR adds two themes

@YardQuit
Copy link
Contributor Author

Thanks, but this just became to complicated to me. I don't really know what to do or why this is in conflict with #10381 or how to solve it without messing things up. Any advice on the best and easiest approach?

@the-mikedavis
Copy link
Member

You can merge this branch with the current Helix master. It might be easier to create a new branch off of the current Helix master though and add the new theme file to it and create a new PR.

@YardQuit
Copy link
Contributor Author

Yes, I will give it a try that, thanks! :)

@YardQuit YardQuit mentioned this pull request Jun 30, 2024
@the-mikedavis
Copy link
Member

Closing in favor of #11063

@YardQuit YardQuit deleted the color_theme_ao branch July 5, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants