Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of diagnostics in Darcula themes #10564

Closed

Conversation

jesusmgg
Copy link
Contributor

@jesusmgg jesusmgg commented Apr 23, 2024

Use dimmer diagnostic colors in Darcula themes.

Specially with long errors current bright colors can make text quickly very hard to read when marked by diagnostic underlines.

Warnings: orange -> dim orange

Old

darcula_solid_dimorange_old

New

darcula_solid_dimorange_new
darcula_dimorange_new

Errors: red -> dim red

Old

darcula_solid_dimred_old

New

darcula_solid_dimred_new
darcula_dimred_new

Info and hints: light grey -> dashed dim grey

Old

darcula_solid_dimgrey_old

New

darcula_solid_dimgrey_new

@jesusmgg jesusmgg changed the title Improve readability of diagnostics in Darcula themes. Improve readability of diagnostics in Darcula themes Apr 23, 2024
@archseer
Copy link
Member

Personally, I find the new colors a lot harder to see.

@jesusmgg
Copy link
Contributor Author

Personally, I find the new colors a lot harder to see.

The PR is about the text readability when marked with underlines actually. I made the underlines dimmer on purpose.

@jesusmgg jesusmgg closed this May 9, 2024
@jesusmgg jesusmgg deleted the theme-darcula-dimmer-diagnostics branch June 17, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants