Read symlink when writing files #10339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirawi
added
C-bug
pascalkuthe
reviewed
Apr 10, 2024
There was a problem hiding this comment.
could you try adding some intuegration tests for this so we catch if this ever regresses again?
Basically create some symlinks and then make sure that writing trough them modifier the original file as expected.
you can take a look at the git symlik tests to see an example ow how to set up tests like that
Co-authored-by: Pascal Kuthe <[email protected]>
kirawi
added
the
S-waiting-on-author
kirawi
added
S-waiting-on-review
pascalkuthe
approved these changes
Apr 11, 2024
the-mikedavis
approved these changes
Apr 12, 2024
dpc
pushed a commit
to dpc/helix
that referenced
this pull request
Apr 18, 2024
Co-authored-by: Pascal Kuthe <[email protected]>
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
Co-authored-by: Pascal Kuthe <[email protected]>
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Co-authored-by: Pascal Kuthe <[email protected]>
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
Co-authored-by: Pascal Kuthe <[email protected]>
Chirikumbrah
pushed a commit
to Chirikumbrah/helix
that referenced
this pull request
Jun 15, 2024
Co-authored-by: Pascal Kuthe <[email protected]>
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Co-authored-by: Pascal Kuthe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10326