Fix scrolling to the end within a popup #10181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthago1
force-pushed
the
bugfix-scroll-popup
branch
from
aa4e303
to
68f7519
Compare
when the available height for the popup is low/small, then it is not possible to scroll until the end Signed-off-by: Ben Fekih, Hichem <[email protected]>
karthago1
force-pushed
the
bugfix-scroll-popup
branch
from
68f7519
to
d72d426
Compare
pascalkuthe
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
Good catch finding this! To be honest I don't like the retroactive patching going on here.
I think this may ultimately be hinting at some design issues with the component API and much larger issues with PopUp (there is for example duplication between area and size, and mutating self in required_size is a huge hack to begin with).
I think this makes sense to fix this way for now but we need to seriously reconsider component/popup in the longterm here. Its turning into a mess
|
I agree, this is not the right way to fix this issue. The mutation inside |
kirawi
added
C-bug
the-mikedavis
approved these changes
Apr 8, 2024
the-mikedavis
changed the title
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
when the available height for the popup is low/small, then it is not possible to scroll until the end Signed-off-by: Ben Fekih, Hichem <[email protected]>
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
when the available height for the popup is low/small, then it is not possible to scroll until the end Signed-off-by: Ben Fekih, Hichem <[email protected]>
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
when the available height for the popup is low/small, then it is not possible to scroll until the end Signed-off-by: Ben Fekih, Hichem <[email protected]>
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
when the available height for the popup is low/small, then it is not possible to scroll until the end Signed-off-by: Ben Fekih, Hichem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the available height for the popup is low/small, then it is not possible to scroll until the end
this recording shows the problem (created by @thomasaarholt)