Handle mouse events based on pointer focus for popups #10126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues of mouse clicks "bleeding" through into the editor when clicked on top of popups. In previous versions, mouse events were ignored and passed into the lower layers which resulted in editor cursor being moved when popup areas are clicked.
sudormrfbin
force-pushed
the
dismiss-popup-on-outside-mouse
branch
from
acf267d
to
a97bf79
Compare
pascalkuthe
requested changes
Apr 3, 2024
| @@ -198,20 +198,29 @@ impl<T: Component> Popup<T> { | |||
| && y < self.area.bottom(); | |||
|
|
|||
| if !mouse_is_within_popup { | |||
| return EventResult::Ignored(None); | |||
| return EventResult::Ignored(Some(self.close_cb())); | |||
There was a problem hiding this comment.
not quite sure how I feel about closing popups without giving their contents a chance to cleanup.
I think we should emulate a c-c press here so the popup gets a chance to cleanup
Suggested change
| return EventResult::Ignored(Some(self.close_cb())); | |
| let _ = self.contents.handle_event(ctrl!(c), cx) | |
| return EventResult::Ignored(Some(self.close_cb())); |
kirawi
added
A-helix-term
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds one behavioral change and one bug fix:
Screencasts of old behavior (click to expand)
Commits have been arranged for ease of review as always.