Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft-wrap enable toggle does not work. #6605

Closed
gibbz00 opened this issue Apr 5, 2023 · 4 comments · Fixed by #6742
Closed

Soft-wrap enable toggle does not work. #6605

gibbz00 opened this issue Apr 5, 2023 · 4 comments · Fixed by #6742
Labels
C-bug Category: This is a bug

Comments

@gibbz00
Copy link
Contributor

gibbz00 commented Apr 5, 2023 •
edited
Loading

Summary

:toggle-option softwrap-enable returns "Key soft-wrap.enable is not toggle-able" when soft-wrap is not set to true before. Works after a :set-option softwrap-enable true.

Platform

Linux

Terminal Emulator

foot

Helix Version

23.03-16-g2bdb58fb
@gibbz00 gibbz00 added the C-bug Category: This is a bug label Apr 5, 2023
@pascalkuthe
Copy link
Member

pascalkuthe commented Apr 5, 2023 •
edited
Loading

You need to set an explicit default value for that setting in your config for toggle to work. The problem is that softwrap.ebale is an option I think and therefore don't picked up as a bool

@gibbz00
Copy link
Contributor Author

gibbz00 commented Apr 8, 2023

Hmm okay, what was the reasoning behind wrapping it in an Option?

gibbz00 pushed a commit to gibbz00/helix that referenced this issue Apr 8, 2023
Fix helix-editor#6605: Remove soft-wrap.enable option wrapping.
1103d39
archseer added a commit that referenced this issue Apr 8, 2023
@archseer
Revert "Fix #6605: Remove soft-wrap.enable option wrapping. (#6656)"
6ebfad1 
This reverts commit af88a3c.
archseer added a commit that referenced this issue Apr 8, 2023
@archseer
Revert "Fix #6605: Remove soft-wrap.enable option wrapping. (#6656)"
58e457a 
This caused a bug that would ignore the global config.

This reverts commit af88a3c.
@pascalkuthe pascalkuthe mentioned this issue Apr 8, 2023
Merged
@pascalkuthe pascalkuthe reopened this Apr 8, 2023
@pascalkuthe pascalkuthe mentioned this issue Apr 13, 2023
Merged
Triton171 pushed a commit to Triton171/helix that referenced this issue Jun 18, 2023
@gibbz00 @Triton171
Fix helix-editor#6605: Remove soft-wrap.enable option wrapping. (heli…
95e91a3 
…x-editor#6656)

Co-authored-by: gibbz00 <[email protected]>
Triton171 pushed a commit to Triton171/helix that referenced this issue Jun 18, 2023
@archseer @Triton171
Revert "Fix helix-editor#6605: Remove soft-wrap.enable option wrappin…
068bc2b 
…g. (helix-editor#6656)"

This caused a bug that would ignore the global config.

This reverts commit af88a3c.
wes-adams pushed a commit to wes-adams/helix that referenced this issue Jul 4, 2023
@gibbz00 @wes-adams
Fix helix-editor#6605: Remove soft-wrap.enable option wrapping. (heli…
5346fd1 
…x-editor#6656)

Co-authored-by: gibbz00 <[email protected]>
wes-adams pushed a commit to wes-adams/helix that referenced this issue Jul 4, 2023
@archseer @wes-adams
Revert "Fix helix-editor#6605: Remove soft-wrap.enable option wrappin…
7346928 
…g. (helix-editor#6656)"

This caused a bug that would ignore the global config.

This reverts commit af88a3c.
@vereym
Copy link

vereym commented Jul 18, 2023

This still seems to be a problem for me (I'm on latest master). Don't know if I'm missing something.

@webdev23
Copy link

webdev23 commented Jan 3, 2024 •
edited
Loading

As shown in https://helix-editor.com/news/release-23-03-highlights , since v23.03
, the commands to toggle text wrapping from Helix, are:

:set soft-wrap.enable true
:set soft-wrap.enable false

Setting a default value in the config.toml seems to be mandatory:

[editor.soft-wrap]
enable = true

smortime pushed a commit to smortime/helix that referenced this issue Jul 10, 2024
@gibbz00
Fix helix-editor#6605: Remove soft-wrap.enable option wrapping. (heli…
675e305 
…x-editor#6656)

Co-authored-by: gibbz00 <[email protected]>
smortime pushed a commit to smortime/helix that referenced this issue Jul 10, 2024
@archseer
Revert "Fix helix-editor#6605: Remove soft-wrap.enable option wrappin…
3d4852f 
…g. (helix-editor#6656)"

This caused a bug that would ignore the global config.

This reverts commit af88a3c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ensure :toggle soft-wrap.enable works by default helix-editor/helix
4 participants
@webdev23 @gibbz00 @pascalkuthe @vereym