Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong output directory created when using current directory pattern (./) in src #29

Closed
jeffreybarke opened this issue Mar 30, 2014 · 0 comments · Fixed by #30
Closed

Wrong output directory created when using current directory pattern (./) in src #29

jeffreybarke opened this issue Mar 30, 2014 · 0 comments · Fixed by #30

Comments

@jeffreybarke
Copy link
Contributor

When using src patterns such as ./img instead of img, an extraneous g/ directory is created in the dest dir. I don't see why one src pattern is to be preferred over the other; both are valid paths and both should work.

This is essentially a duplicate of #28 that @dmcass opened. There is substance here, however his fix was incorrect. Instead of hardcoding a + 1 (cc764d9), it seems better to always path.normalize filepath in the same way that fileDir is normalized.
jeffreybarke added a commit to jeffreybarke/grunt-smushit that referenced this issue Mar 30, 2014
@jeffreybarke
Fixes heldr#29
19b829f 
* Update getSubPath function in /tasks/smushit.js to normalize
  filepath parameter similar to how the fileDir parameter is
  normalized. This fixes heldr#29, in which src patterns such as ./img
  create an extraneous g/ directory in the dest directory.
* Update version in package.json to v1.2.1.
* Update release history in README with v.1.2.1 deets.
@jeffreybarke jeffreybarke mentioned this issue Mar 30, 2014
Merged
@heldr heldr closed this as completed in #30 Apr 2, 2014
heldr added a commit that referenced this issue Apr 2, 2014
@heldr
Merge pull request #30 from jeffreybarke/master
80c3183 
Fixes #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #29 jeffreybarke/grunt-smushit
1 participant
@jeffreybarke