Gssapi sequence fixes #1248
Open
Gssapi sequence fixes #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2024 10:30
Sequence errors are supplemental information in GSSAPI. This means that they are not fatal, unless they are returned alongside a failure error code. This change makes our behaviour the same as MIT's - sequence errors are non-fatal, and return valid output information.
A typo in _gssapi_msg_order_check means that sequence numbers received out of sequence are not correctly added to the internal order array.
jaltman
reviewed
Jun 20, 2024
|
RFC2743 1.2.3: Per-Message Replay Detection and Sequencing describes the compliant behavior implemented by this pull request. |
jaltman
requested changes
Jun 28, 2024
jaltman
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fixes for issues with checking sequence ordering in GSSAPI