kdc: Add support for PKINIT freshness #1182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsutton24
force-pushed
the
kdc-pkinit-freshness
branch
2 times, most recently
from
a70dd99
to
3bb2264
Compare
nicowilliams
reviewed
Jan 4, 2024
nicowilliams
reviewed
Jan 4, 2024
| * Match Windows by preferring the authenticator nonce over the one in the | ||
| * request body. | ||
| */ | ||
| r->ek.nonce = _kdc_pk_nonce(pkp); |
There was a problem hiding this comment.
Does this break interop with earlier versions of Heimdal?
There was a problem hiding this comment.
I don’t know. At any rate, we haven’t noticed this KDC‐side change cause any problems interoperating with the Heimdal client.
There was a problem hiding this comment.
Meaning that you deployed this fix on the KDCs without also upgrading all clients?
nicowilliams
reviewed
Jan 4, 2024
|
Except for my question about interop this looks great to me, and thank you! (And sorry for the delay.) |
|
This branch now has conflicts. |
Assists Samba to address CVE-2022-2031 This allows the plugin to check the endtime of a ticket against the KDC's current time, to see if the ticket will expire in the next two minutes. Samba BUG: https://bugzilla.samba.org/show_bug.cgi?id=15047 Signed-off-by: Joseph Sutton <[email protected]>
This matches the behaviour of the Windows KDC. Signed-off-by: Joseph Sutton <[email protected]>
For a PK-INIT request, we want to have the local krbtgt key available to encrypt a new freshness token, and to decrypt a freshness token sent us by a client. Signed-off-by: Joseph Sutton <[email protected]>
Clients indicating support for PKINIT Freshness (by means of an empty PADATA_AS_FRESHNESS type) will receive in the reply a freshness token to be included in the client’s PK-INIT request which proves the client’s recent possession of the private key. The require-pkinit-freshness option, if enabled, will reject PK-INIT requests that lack this token. Freshness tokens are only supported with the PA-PK-AS-REQ padata type. The PA-PK-AS-REQ-Win2k type has no field to contain a freshness token. Signed-off-by: Joseph Sutton <[email protected]>
jsutton24
force-pushed
the
kdc-pkinit-freshness
branch
from
3bb2264
to
154c072
Compare
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is interoperable with that of Windows.