Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Fixes for the debugger #5673

Merged
merged 7 commits into from
Aug 6, 2024
Merged

🪲 Fixes for the debugger #5673

merged 7 commits into from
Aug 6, 2024

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Jul 23, 2024

Fixes several bugs for the debugger, including:

  • Now the debugger disables the continue button, so the only possibility to continue executing the program is when there are no instructions being executed.
  • Fixed the problem when the debugger did not show the turtle canvas.
  • Overlays the variable box on top of the output window, so now there's space for it when the turtle also shows in the program.

fixes #5672
fixes #5671
fixes #5670
fixes #4775

How to test

  • Copy and paste this program in level 2:
print I will draw a plus
angle is 90
forward 20
sleep 1
turn -90
color blue
forward 20
sleep 1
turn 90
color red
forward 20
sleep 1
turn -90
color black
forward 20
sleep 1
turn -90
color blue
forward 20
sleep 1
turn 90
color red
forward 20
sleep 1
turn -90
color black
forward 20
sleep 1
turn -90
color blue
forward 20
sleep 1
turn 90
color red
forward 20
sleep 1
turn -90
color black
forward 20
sleep 1
turn -90
color blue
forward 20
sleep 1
turn 90
color red
forward 20

Check that the plus is drawn correctly and that you can't continue pressing continue when the turtle is drawing or the program is sleeping. Once it finishes, check that the variable box is being shown correctly.

I also updated and added a few tests.

@boryanagoncharenko boryanagoncharenko self-assigned this Aug 6, 2024
Copy link
Contributor

mergify bot commented Aug 6, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

* Using the proper id for the stop button
* Disabling and enabling the continue button depending if there's an instruction being executed
Copy link
Contributor

mergify bot commented Aug 6, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3568d97 into main Aug 6, 2024
12 checks passed
@mergify mergify bot deleted the debug-fixes branch August 6, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment