Region boundaries from gridded mask + comphrehensive tutorials #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major changes: - Changed high-level API, replacing various function arguments with `xgcm.Grid` instances - Replaced cartesian polygon orientation formula with a spherical polygon one, based on a South-Pole stereographic projection - Makes circum-navigating sections more robust - Adds tests - Introduce new `GriddedRegion` object which combines section information with grid information - Introduced `MaskRegions` which are initialized from a Boolean mask on the model's tracer grid (uses `contourpy` to find indices of contours) - Renamed class `Basin` -> `Region` Minor changes:
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
Changed high-level API, replacing various function arguments with
xgcm.GridinstancesReplaced cartesian polygon orientation formula with a spherical polygon one, based on a South-Pole stereographic projection
Makes circum-navigating sections more robust
Adds tests
Introduce new
GriddedRegionobject which combines section information with grid informationIntroduced
MaskRegionswhich are initialized from a Boolean mask on the model's tracer grid (usescontourpyto find indices of contours)Renamed class
Basin->Region