Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supportment for non-centralized pinhole cameras data #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leonwu0108
Copy link

Add supportment for non-centralized pinhole cameras data (like BlendedMVS).

@hbb1
Copy link
Owner

hbb1 commented Jun 12, 2024

Thank you! Does it also work for centralized pinhole camera? I intend to keep the original data format unaffected.

@leonwu0108
Copy link
Author

@hbb1 Yes, it works for both. The added codes simply read principal point coordinates from the COLMAP cameras.txt file and apply them to calculate the projection matrix, referring to this issue.

@hbb1
Copy link
Owner

hbb1 commented Jun 23, 2024

Hi, Thank you. However, the TSDF and the depth normal calculation are assumed to be used with centralized pinhole camera. It still needs some time to make some changes and tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants