chore: temporarily disable op_require_read_file (denoland#15433)

hayd · Aug 9, 2022 · d6f789e · d6f789e
1 parent 1c2ec1f
commit d6f789e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/cli/tests/integration/compat_tests.rs b/cli/tests/integration/compat_tests.rs
@@ -173,6 +173,7 @@ fn native_modules_as_global_vars() {
   assert!(out.contains("true"));
 }
 
+#[ignore] // todo(dsherret): re-enable
 #[test]
 fn ext_node_cjs_execution() {
   let (out, _err) = util::run_and_collect_output_with_args(

diff --git a/ext/node/01_require.js b/ext/node/01_require.js
@@ -476,7 +476,7 @@
     if (typeof options === "object" && options !== null) {
       if (ArrayIsArray(options.paths)) {
         const isRelative = core.opSync(
-          "op_require_specifier_is_relative",
+          "op_require_is_request_relative",
           request,
         );
 

diff --git a/ext/node/lib.rs b/ext/node/lib.rs
@@ -311,7 +311,6 @@ fn op_require_try_self(
 }
 
 #[op]
-fn op_require_read_file(filename: String) -> Result<String, AnyError> {
-  let contents = std::fs::read_to_string(filename)?;
-  Ok(contents)
+fn op_require_read_file(_filename: String) -> Result<String, AnyError> {
+  todo!("not implemented");
 }