feat: emit files on demand and fix racy emit (denoland#15220)

cli/args/mod.rs

@@ -286,6 +286,11 @@ impl CliOptions {
  self.flags.enable_testing_features
  }
 
+ /// If the --inspect or --inspect-brk flags are used.
+ pub fn is_inspecting(&self) -> bool {
+ self.flags.inspect.is_some() || self.flags.inspect_brk.is_some()
+ }
+
  pub fn inspect_brk(&self) -> Option<SocketAddr> {
  self.flags.inspect_brk
  }

cli/cache/check.rs

@@ -22,7 +22,7 @@ impl TypeCheckCache {
  Err(err) => {
  log::debug!(
  concat!(
- "Failed creating internal type checking cache. ",
+ "Failed loading internal type checking cache. ",
  "Recreating...\n\nError details:\n{:#}",
  ),
  err
@@ -35,7 +35,7 @@ impl TypeCheckCache {
  Err(err) => {
  log::debug!(
  concat!(
- "Unable to create internal cache for type checking. ",
+ "Unable to load internal cache for type checking. ",
  "This will reduce the performance of type checking.\n\n",
  "Error details:\n{:#}",
  ),
@@ -233,7 +233,7 @@ mod test {
  cache.set_tsbuildinfo(&specifier1, "test");
  assert_eq!(cache.get_tsbuildinfo(&specifier1), Some("test".to_string()));
 
- // recreating the cache should not remove the data because the CLI version and state hash is the same
+ // recreating the cache should not remove the data because the CLI version is the same
  let conn = cache.0.unwrap();
  let cache =
  TypeCheckCache::from_connection(conn, "2.0.0".to_string()).unwrap();

cli/cache/common.rs

@@ -1,16 +1,37 @@
 // Copyright 2018-2022 the Deno authors. All rights reserved. MIT license.
 
+use std::hash::Hasher;
+
 use deno_core::error::AnyError;
 use deno_runtime::deno_webstorage::rusqlite::Connection;
 
-/// Very fast non-cryptographically secure hash.
-pub fn fast_insecure_hash(bytes: &[u8]) -> u64 {
- use std::hash::Hasher;
- use twox_hash::XxHash64;
+/// A very fast insecure hasher that uses the xxHash algorithm.
+#[derive(Default)]
+pub struct FastInsecureHasher(twox_hash::XxHash64);
+
+impl FastInsecureHasher {
+ pub fn new() -> Self {
+ Self::default()
+ }
+
+ pub fn write_str(&mut self, text: &str) -> &mut Self {
+ self.write(text.as_bytes());
+ self
+ }
+
+ pub fn write(&mut self, bytes: &[u8]) -> &mut Self {
+ self.0.write(bytes);
+ self
+ }
+
+ pub fn write_u64(&mut self, value: u64) -> &mut Self {
+ self.0.write_u64(value);
+ self
+ }
 
- let mut hasher = XxHash64::default();
- hasher.write(bytes);
- hasher.finish()
+ pub fn finish(&self) -> u64 {
+  self.0.finish()
+ }
 }
 
 /// Runs the common sqlite pragma.

cli/cache/disk_cache.rs

@@ -3,13 +3,6 @@
 use crate::fs_util;
 use crate::http_cache::url_to_filename;
 
-use super::CacheType;
-use super::Cacher;
-use super::EmitMetadata;
-
-use deno_ast::ModuleSpecifier;
-use deno_core::error::AnyError;
-use deno_core::serde_json;
 use deno_core::url::Host;
 use deno_core::url::Url;
 use std::ffi::OsStr;
@@ -154,77 +147,6 @@ impl DiskCache {
  fs_util::atomic_write_file(&path, data, crate::http_cache::CACHE_PERM)
  .map_err(|e| with_io_context(&e, format!("{:#?}", &path)))
  }
-
- fn get_emit_metadata(
- &self,
- specifier: &ModuleSpecifier,
- ) -> Option<EmitMetadata> {
- let filename = self.get_cache_filename_with_extension(specifier, "meta")?;
- let bytes = self.get(&filename).ok()?;
- serde_json::from_slice(&bytes).ok()
- }
-
- fn set_emit_metadata(
- &self,
- specifier: &ModuleSpecifier,
- data: EmitMetadata,
- ) -> Result<(), AnyError> {
- let filename = self
- .get_cache_filename_with_extension(specifier, "meta")
- .unwrap();
- let bytes = serde_json::to_vec(&data)?;
- self.set(&filename, &bytes).map_err(|e| e.into())
- }
-}
-
-// todo(13302): remove and replace with sqlite database
-impl Cacher for DiskCache {
- fn get(
- &self,
- cache_type: CacheType,
- specifier: &ModuleSpecifier,
- ) -> Option<String> {
- let extension = match cache_type {
- CacheType::Emit => "js",
- CacheType::SourceMap => "js.map",
- CacheType::Version => {
- return self.get_emit_metadata(specifier).map(|d| d.version_hash)
- }
- };
- let filename =
- self.get_cache_filename_with_extension(specifier, extension)?;
- self
- .get(&filename)
- .ok()
- .and_then(|b| String::from_utf8(b).ok())
- }
-
- fn set(
- &self,
- cache_type: CacheType,
- specifier: &ModuleSpecifier,
- value: String,
- ) -> Result<(), AnyError> {
- let extension = match cache_type {
- CacheType::Emit => "js",
- CacheType::SourceMap => "js.map",
- CacheType::Version => {
- let data = if let Some(mut data) = self.get_emit_metadata(specifier) {
- data.version_hash = value;
- data
- } else {
- EmitMetadata {
- version_hash: value,
- }
- };
- return self.set_emit_metadata(specifier, data);
- }
- };
- let filename = self
- .get_cache_filename_with_extension(specifier, extension)
- .unwrap();
- self.set(&filename, value.as_bytes()).map_err(|e| e.into())
- }
 }
 
 #[cfg(test)]