RFC: remove ndc-client #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I approve this message. |
hasura-bot
pushed a commit
to hasura/graphql-engine
that referenced
this pull request
Apr 2, 2024
Ref: hasura/ndc-spec#130 - Avoid using NDC client code from ndc-spec for ndc API requests. Instead, copy the client related code from ndc-spec into v3-engine. - Code is copied into `.../execute/ndc/client.rs` module with the following changes: - API, configuration and error type related code is consolidated into a single `client.rs` module. - Derive error implementation for the error type using `thiserror::Error` derive-macro - Replace `opentelemetry` crate usage with `tracing_util` with necessary changes - Lot of redundant logic still there which will be addressed through https://hasurahq.atlassian.net/browse/APG-53 V3_GIT_ORIGIN_REV_ID: 5766e407495c483cc4814d1286121b233aed3af0
SamirTalwar
previously approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered